This repository has been archived by the owner on Jan 16, 2025. It is now read-only.
Update dependencies #107
Merged
Update dependencies #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
moCello
force-pushed
the
plonk-0.19
branch
4 times, most recently
from
a6a7928 to
885a51f
Compare
moCello
requested review from
miloszm,
xevisalle,
Daksh14,
herr-seppia and
ureeves
ureeves
approved these changes
May 1, 2024
tests/derive_keys.rs
Outdated
There was a problem hiding this comment.
As much as I would like to take credit here, I'm afraid that I initially changed the string that we hash to obtain the secret key from "SSK" to "SK" which was not a good idea in hindsight... @herr-seppia helped a lot finding that mistake and suggested to add a test so that this doesn't happen again.
xevisalle
suggested changes
May 1, 2024
xevisalle
approved these changes
May 1, 2024
- Replace `dusk-schnorr` with `jubjub-schnorr` 0.2 - Replace `dusk-bls12_381-sign` with `bls12_381-bls` 0.2 - Update `dusk-poseidon` 0.31 -> 0.33 - Update `dusk-plonk` 0.16 -> 0.19 - Update `poseidon-merkle` 0.3 -> 0.5 - Update `phoenix-core` 0.21 -> 0.26 - Update 'rusk-abi' 0.13.0-rc -> 0.14.0-rc - Update `stake-contract-types` 0.0.1-rc.2 -> 0.1.0-rc - Rename `Wallet::public_key` to `Wallet::stake_public_key` - Rename `Wallet::public_spend_key` to `Wallet::public_key` - Rename `derive_sk` to `derive_stake_sk` - Rename `derive_ssk` to `derive_sk` - Rename `retrieve_sk` to `retrieve_stake_sk` - Rename `retrieve_ssk` to `retrieve_sk` - Rename `ffi::public_spend_key` to `ffi::public_key - Rename `UnprovenTransactionInput::pk_r` to `note_pk_prime`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #106